Skip to content

Log_softmax backward case#1: axis=-1#32180

Merged
Xreki merged 13 commits intoPaddlePaddle:developfrom
AshburnLee:log_softmax_back
Apr 14, 2021
Merged

Log_softmax backward case#1: axis=-1#32180
Xreki merged 13 commits intoPaddlePaddle:developfrom
AshburnLee:log_softmax_back

Conversation

@AshburnLee
Copy link
Copy Markdown
Contributor

@AshburnLee AshburnLee commented Apr 10, 2021

PR types

Performance optimization

PR changes

OPs

Describe

实现log_softmax的cuda版本。如下是前向计算的3个case。当前PR实现case#1 的反向计算。

if (inner_size == 1) {
    if (dim_size <= 1024 && dim_size * sizeof(T) <= 4096) {
        case#1  
    } else {
        case#2
    }
} else {
    case#3
}

@paddle-bot-old
Copy link
Copy Markdown

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Copy Markdown
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 有3处小的修改建议,可以下个PR再改。

Comment thread paddle/fluid/operators/log_softmax_op.cu
Comment thread paddle/fluid/operators/log_softmax_op.cu
Comment thread paddle/fluid/operators/log_softmax_op.cu
@Xreki Xreki merged commit 5dc0a6e into PaddlePaddle:develop Apr 14, 2021
@AshburnLee AshburnLee deleted the log_softmax_back branch April 15, 2021 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants