Skip to content

Delete grpc.cmake/distribeted/distributed_ops #32166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 14, 2021
Merged

Delete grpc.cmake/distribeted/distributed_ops #32166

merged 4 commits into from
Apr 14, 2021

Conversation

@tianshuo78520a
Copy link
Collaborator

@tianshuo78520a tianshuo78520a commented Apr 9, 2021 •
edited by raindrops2sea
Loading

PR types

Others

PR changes

Others

Describe

Delete grpc.cmake/distribeted/distributed_ops

清理原因：grpc相关的老代码（分布式现在使用brpc）以及分布式已废弃的一些其他代码都可以删除，估计有5万行
需要分三步（本PR完成前两个）：

  • cmake下 grpc.cmake 可删
  • C++端的几个目录：operator目录下 distributed/distributed_ops目前已被废弃(存放的都是分布式1.x的相关代码)，可删
  • Python端(这个有一点工作量，2.0升级的时候没有做完全的重写，import了不少函数)
    • python/paddle/fluid/transpiler (1.x 分布式遗留代码) 可删
    • python/paddle/fluid/incubate/data_generator 1.x dataset遗留代码，可删
    • python/paddle/fluid/contrib/utils 可删
    • python/paddle/fluid/contrib/reader 可删
    • python/paddle/fluid/distributed 可删（需确认）
    • python/paddle/fluid/incubate/fleet 不可直接删除，目前2.0 有部分功能依赖了此目录结构，可进行相应的代码迁移后整体删除（需确认）

@paddle-bot-old
Copy link

paddle-bot-old bot commented Apr 9, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Avin0323
Avin0323 approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@Avin0323 Avin0323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for OP-benchmark-CI

luotao1
luotao1 approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luotao1
Copy link
Contributor

luotao1 commented Apr 13, 2021

下一个PR可以把 tools/check_file_diff_approvals.sh中关于paddle/fluid/operators/distributed/send_recv.proto.in的检查给删了。

@tianshuo78520a
Copy link
Collaborator Author

tianshuo78520a commented Apr 13, 2021

下一个PR可以把 tools/check_file_diff_approvals.sh中关于paddle/fluid/operators/distributed/send_recv.proto.in的检查给删了。

好的

seiriosPlus
seiriosPlus approved these changes Apr 13, 2021
View reviewed changes
Copy link
Collaborator

@seiriosPlus seiriosPlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 22ea4c3 into PaddlePaddle:develop Apr 14, 2021
@luotao1
Copy link
Contributor

luotao1 commented Apr 14, 2021

可以把WITH_GRPC的编译选项都去掉了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seiriosPlus seiriosPlus seiriosPlus approved these changes

@luotao1 luotao1 luotao1 approved these changes

@kolinwei kolinwei kolinwei approved these changes

@Avin0323 Avin0323 Avin0323 approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

@raindrops2sea raindrops2sea raindrops2sea approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tianshuo78520a @luotao1 @seiriosPlus @kolinwei @Avin0323 @XieYunshen @raindrops2sea