add layer.to api #32040
Merged
add layer.to api #32040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
ForFishes
requested changes
Apr 7, 2021
| for key, buf in self._buffers.items(): | ||
| self._buffers[key] = func(buf, place, dtype, blocking) | ||
|
|
||
| def to(self, place=None, dtype=None, blocking=None): |
Member
There was a problem hiding this comment.
这里是不是需要支持，用户输入“cuda”，可以自动判断当前cuda place id，从而to到相应的place。
Contributor
Author
There was a problem hiding this comment.
place参数的取值已经可以 支持paddle.set_device 所支持的取值。
chenwhql
reviewed
Apr 9, 2021
paddle/fluid/pybind/imperative.cc
Outdated
| } | ||
|
|
||
| static void InitVarBaseFromTensorWithArgDefault( | ||
|
|
python/paddle/device.py
Outdated
| x2 = paddle.zeros(name='x2', shape=[1, 2], dtype='int32') | ||
| data = paddle.stack([x1,x2], axis=1) | ||
| """ | ||
| def _make_device(device): |
Contributor
There was a problem hiding this comment.
maybe _convert_to_place is a better name?
| Cast the parameters and buffers of Layer by the give place, dtype and blocking. | ||
| Parameters: | ||
| place(str|paddle.CPUPlace|paddle.CUDAPlace()|paddle.CUDAPinnedPlace()|None, optional): The device place of the Layer which want to be stored. |
Contributor
There was a problem hiding this comment.
统一下，paddle.CPUPlace后面要不要也加括号？
Contributor
There was a problem hiding this comment.
The device place of the Layer，device和place有重复的意思，改成The device of the Layer?
Contributor
There was a problem hiding this comment.
参数名要不要直接使用device？和set_deivce API统一？
MingMingShangTian
force-pushed
the
layer_to
branch
from
ead7476 to
bc85ae4
Compare
MingMingShangTian
force-pushed
the
layer_to
branch
from
febf2f6 to
fff1241
Compare
MingMingShangTian
force-pushed
the
layer_to
branch
from
fff1241 to
bc85ae4
Compare
MingMingShangTian
force-pushed
the
layer_to
branch
from
1cd85c7 to
ead7476
Compare
chenwhql
reviewed
Apr 12, 2021
| Parameters: | ||
| device(str|paddle.CPUPlace()|paddle.CUDAPlace()|paddle.CUDAPinnedPlace()|None, optional): The device of the Layer which want to be stored. | ||
| If None, the place is the same with the origin Tensor. If device is string, it can be ``cpu``, ``gpu:x`` and ``xpu:x``, where ``x`` is the |
Contributor
Author
There was a problem hiding this comment.
Done, thanks.
| If None, the place is the same with the origin Tensor. If device is string, it can be ``cpu``, ``gpu:x`` and ``xpu:x``, where ``x`` is the | ||
| index of the GPUs or XPUs. Default: None. | ||
| dtype(str|core.VarDesc.VarType|None, optional): The type of the data. If None, the dtype is the same with the origin Tensor. Default: None. |
Contributor
Author
There was a problem hiding this comment.
Done, thanks.
lanxianghit
previously approved these changes
Apr 12, 2021
TCChenlong
reviewed
Apr 12, 2021
| Cast the parameters and buffers of Layer by the give device, dtype and blocking. | ||
| Parameters: | ||
| device(str|paddle.CPUPlace()|paddle.CUDAPlace()|paddle.CUDAPinnedPlace()|None, optional): The device of the Layer which want to be stored. |
MingMingShangTian
dismissed stale reviews from lanxianghit, ForFishes, and chenwhql
via
0f62fa0
chenwhql
approved these changes
Apr 13, 2021
lanxianghit
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
add layer.to api