Del cudnn6 code2#31986
Merged
luotao1 merged 8 commits intoPaddlePaddle:developfrom Apr 6, 2021
tianshuo78520a:del_cudnn6_code2
Merged
Del cudnn6 code2#31986luotao1 merged 8 commits intoPaddlePaddle:developfrom tianshuo78520a:del_cudnn6_code2
luotao1 merged 8 commits intoPaddlePaddle:developfrom
tianshuo78520a:del_cudnn6_code2
Conversation
|
Thanks for your contribution! |
luotao1
reviewed
Apr 2, 2021
cmake/configure.cmake
Outdated
|
|
||
| if(NOT CUDNN_FOUND) | ||
| message(FATAL_ERROR "Paddle needs cudnn to compile") | ||
| endif() |
Contributor
There was a problem hiding this comment.
100行的判断应该放在104行后面比较合理，先判断有没有CUDNN，再判断版本大小。
luotao1
reviewed
Apr 2, 2021
| __macro(cudnnSetActivationDescriptor); \ | ||
| __macro(cudnnGetActivationDescriptor); \ | ||
| __macro(cudnnDestroyActivationDescriptor); \ | ||
| __macro(cudnnSetRNNDescriptor_v6); |
luotao1
reviewed
Apr 2, 2021
| __macro(cudnnDestroyRNNDescriptor); \ | ||
| __macro(cudnnSetTensorNdDescriptorEx); | ||
|
|
||
| CUDNN_DNN_ROUTINE_EACH(DECLARE_DYNAMIC_LOAD_CUDNN_WRAP) |
| __macro(cudnnGetConvolutionBackwardDataAlgorithm); \ | ||
| __macro(cudnnSetRNNDescriptor); | ||
| CUDNN_DNN_ROUTINE_EACH_AFTER_R3_LESS_R8(DECLARE_DYNAMIC_LOAD_CUDNN_WRAP) | ||
| #endif |
Contributor
There was a problem hiding this comment.
CUDNN_DNN_ROUTINE_EACH_AFTER_R3_LESS_R8 应该要留着，改成
#if CUDNN_VERSION >= 7000 && CUDNN_VERSION < 8000
CUDNN_DNN_ROUTINE_EACH_AFTER_R7_LESS_R8？
cudnn.cc中也要做相应修改
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Del cudnn6 code2