Fix segment Fault from set_value #31891
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Describe
Fix segment Fault from set_value
背景
set_value在 append_op时,始终是根据self.block进行添加的,这导致在sub_block中 inplace 修改一个来自global_block的 var 会出现 op 误塞到 global_block中,导致提前非法访问了子block中未经初始化的Tensor,出现segmention Faule,引起极度难以排查的bug。一个触发bug的样例: