Delete cudnn6 code #31835
Merged
Delete cudnn6 code #31835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
luotao1
reviewed
Mar 24, 2021
| platform::errors::Unimplemented("Unexpected CUDNN pooling mode.")); | ||
| } | ||
| } | ||
| #else |
luotao1
reviewed
Mar 25, 2021
| static constexpr size_t kNUM_CUDNN_FWD_ALGS = 1; | ||
| static constexpr size_t kNUM_CUDNN_BWD_FILTER_ALGS = 1; | ||
| static constexpr size_t kNUM_CUDNN_BWD_DATA_ALGS = 1; | ||
| #elif CUDNN_VERSION_MIN(6, 0, 5) |
Contributor
There was a problem hiding this comment.
Paddle/paddle/fluid/platform/cudnn_helper.h
Lines 66 to 67 in e787e7f
CUDNN_VERSION_MIN(6, 0, 5) 表示>=6.0.5，因此37-42行也不能删
luotao1
approved these changes
Mar 27, 2021
Xreki
approved these changes
Mar 29, 2021
Contributor
Xreki
left a comment
Xreki
left a comment
There was a problem hiding this comment.
LGTM. 若cudnn6以下不再支持了，其实platform/dynload/cudnn.h的实现可以简化一下，另外是不是代码里面最好加一个对CUDNN_VERSION的静态的assert检查？
Contributor
@tianshuo78520a 可以在下一个PR里改一下。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Delete cudnn6 code