Skip to content

Update eigen version to f612df27 #31832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 31, 2021
Merged

Update eigen version to f612df27 #31832

merged 7 commits into from
Mar 31, 2021

Conversation

@Avin0323
Copy link
Contributor

@Avin0323 Avin0323 commented Mar 24, 2021 •
edited
Loading

PR types

Others

PR changes

Others

Describe

升级eigen3版本至f612df27（2021.03.16）。

  • 删除因旧版本导致的编译/单测错误而添加的patch修复文件；
  • 解决新版本下个别编译/单测问题：
    • eigen存在bfloat16，不使用using bfloat16的别名；
    • pow调用存在小数点后7位的误差，单测改用np.allclose判断；

升级后效果：

  • 编译时间基本保持一致；
  • 预测动态库单GPU架构减少6M(250M->244M)；
  • Whl单GPU架构减少5M(120M->115M)；

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 24, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

luotao1
luotao1 approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 495e7f9 into PaddlePaddle:develop Mar 31, 2021
@Avin0323 Avin0323 mentioned this pull request Mar 31, 2021
Merged
@Avin0323 Avin0323 deleted the update-eigen-version branch April 6, 2021 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luotao1 luotao1 luotao1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Avin0323 @luotao1