-
Notifications
You must be signed in to change notification settings - Fork 6k
Support control flow in DataParallel #31625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ForFishes
merged 42 commits into
PaddlePaddle:develop
from
ForFishes:support_control_flow
Apr 1, 2021
Merged
Changes from 14 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
e4f2752
fix reducer
ForFishes 5bf0086
add utest
ForFishes 449e090
fix untest
ForFishes 26d1b48
support control flow
ForFishes a798b97
support control flow
ForFishes 45fed37
fix utest
ForFishes 32b2ab5
fix bug
ForFishes c6c55f4
add utest
ForFishes 930a58f
fix utest
ForFishes 7fbb5a2
fix untest
ForFishes 2583f1c
fix bckl
ForFishes 70716fc
fix utest
ForFishes 2143ff5
support fleet
ForFishes 7706e9d
fix comment
ForFishes a4212df
fix fleet api
ForFishes dae49d7
fix utest
ForFishes 2d4f4d5
fix bug
ForFishes cc7fb0c
fix comment
ForFishes ac3e2c0
fix bug
ForFishes 3f541fe
fix files
ForFishes 5f3a3fd
fix utest
ForFishes 97d08eb
fix utest
ForFishes a356f61
add sync buffer and param
ForFishes 42e0c11
add sync param
ForFishes 39dab1a
fix bug
ForFishes e4f5a4d
fix utest
ForFishes a807956
fix cmake
ForFishes 8f67e1f
fix coverage
ForFishes be4072b
add gradient check
ForFishes 93bac9a
fix coverage
ForFishes 1ce2b2b
fix utest
ForFishes e619554
add test for nonevar && find_unused_parameters
ForFishes 037c225
supoort xpu in sync_parameters_buffers
ForFishes 8f25efa
fix xpu
ForFishes 9997354
fix ctest
ForFishes 0dee9fd
add test for dataparallel
ForFishes 8ad02cc
fix utest
ForFishes 85a758b
fix comment
ForFishes 7a9c0a9
fix small bug for redcuer
ForFishes c3af47e
fix parallel_dygraph_dataparallel
ForFishes d934171
solve compute stream & comm stream conflict
ForFishes 39caee0
fix the bug of sparse embedding
ForFishes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -64,6 +64,9 @@ class ParallelContext { | |
| // if CPU, should do nothing. | ||
| virtual void WaitComm(int ring_id) = 0; | ||
|
|
||
| // synchorize compute stream | ||
| virtual void SynchronizeCompute() = 0; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 亮哥,顺路把SynchronizeCompute在bkcl_context里面也加下哈~
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 已经添加。 |
||
|
|
||
| inline int GetNRings() const { return strategy_.nrings_; } | ||
|
|
||
| inline int64_t GetNRanks() const { return strategy_.nranks_; } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个TODO和上面那个TODO帮忙删一下0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok。