Skip to content

Conversation

@lidanqing-vv
Copy link
Contributor

@lidanqing-vv lidanqing-vv commented Feb 26, 2021

PR types

Others

PR changes

Others

Describe

Upgrade oneDNN 2.2
cherry-pick #30295 and #31347

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@lidanqing-vv lidanqing-vv marked this pull request as ready for review March 4, 2021 09:36
@lidanqing-vv lidanqing-vv reopened this Mar 4, 2021
@lidanqing-vv lidanqing-vv force-pushed the release/2.0-cherrypick-2.2 branch from 6a51015 to 7e888e1 Compare March 11, 2021 10:06
@lidanqing-vv lidanqing-vv changed the title [Not for 2.0.1] [Draft] Update of onednn to 2.2 (#31067) Cherry-pick hardswish and update of onednn to 2.2 Mar 11, 2021
@lidanqing-vv lidanqing-vv force-pushed the release/2.0-cherrypick-2.2 branch 2 times, most recently from 1828dd1 to 8a9a1b0 Compare March 12, 2021 23:44
Wojciech Uss and others added 2 commits March 13, 2021 16:07
* upgrade oneDNN version to 2.0 master branch

* - Added workarounds for new lib onednn change

* fix regex

Co-authored-by: Jacek Czaja <[email protected]>
@lidanqing-vv lidanqing-vv force-pushed the release/2.0-cherrypick-2.2 branch from 8a9a1b0 to d6eb8c0 Compare March 13, 2021 21:40
@lidanqing-vv lidanqing-vv force-pushed the release/2.0-cherrypick-2.2 branch from d6eb8c0 to ad23427 Compare March 13, 2021 22:12
@lidanqing-vv lidanqing-vv force-pushed the release/2.0-cherrypick-2.2 branch from ad23427 to 6c393bf Compare March 14, 2021 03:13
@lidanqing-vv
Copy link
Contributor Author

@jczaja @wojtuss Please review.
Since hardswish PR is related to other 2 PRs and having some conflicts issues, let's merge this first.

@lidanqing-vv lidanqing-vv changed the title Cherry-pick hardswish and update of onednn to 2.2 Upgrade oneDNN 2.2 Mar 15, 2021
@luotao1
Copy link
Contributor

luotao1 commented Mar 15, 2021

Please write the original cherry-pick PR in the Describe.

@lidanqing-vv
Copy link
Contributor Author

lidanqing-vv commented Mar 15, 2021

Please write the original cherry-pick PR in the Describe.

This cherry-pick is related with oneDNN upgrade PRs #30295 #31473
但是我没有直接cherry-pick 31473,因为31347的其他内容是revert之前的一些改变,之前因为Mobilenet性能下降,所以改了一些,现在升级到oneDNN2.2,性能不下降了。

@lidanqing-vv lidanqing-vv changed the title Upgrade oneDNN 2.2 cherry-pick #30295 and #30347: Upgrade oneDNN 2.2 Mar 15, 2021
@lidanqing-vv lidanqing-vv changed the title cherry-pick #30295 and #30347: Upgrade oneDNN 2.2 cherry-pick #30295 and #31347: Upgrade oneDNN 2.2 Mar 15, 2021
@lidanqing-vv
Copy link
Contributor Author

hard-swish PR需要oneDNN2.2,但是我这次没把hard swish一起cherry-pick,因为昨天发现涉及5个PR,很多冲突。先把这个涉及2个PR的合入。

Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidanqing-vv
Copy link
Contributor Author

lidanqing-vv commented Mar 15, 2021

@luotao1 这个PR可以合入的。
这个合入之后,我们要cherry-pick hard-siwsh 相关的3个PR,还有一个matmul fix的那个PR。 这两个fix都想这个月底前合入到release/2.0 给 2.0.2 的

Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Superjomn Superjomn merged commit f3b0f8d into PaddlePaddle:release/2.0 Mar 16, 2021
@lidanqing-vv lidanqing-vv deleted the release/2.0-cherrypick-2.2 branch June 20, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants