Skip to content

Conversation

@FrostML
Copy link
Contributor

@FrostML FrostML commented Feb 23, 2021

PR types

Others

PR changes

Others

Describe

Add cublas_handle() to expose cublas_handle for ops.
This is used for custom op faster transformer.

@FrostML FrostML requested a review from guoshengCS February 23, 2021 11:14
@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@FrostML FrostML requested a review from zhiqiu February 24, 2021 03:32
return context()->CudnnHandle();
}

cublasHandle_t CUDADeviceContext::get_cublas_handle() const {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest get_cublas_handle() -> cublas_handle(), keep consistent with other function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks.

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrostML FrostML changed the title Add get_cublas_handle() Add cublas_handle() to expose cublas_handle to ops Feb 24, 2021
@FrostML FrostML merged commit ae2be49 into PaddlePaddle:develop Feb 24, 2021
FrostML added a commit to FrostML/Paddle that referenced this pull request Feb 24, 2021
* add get_cublas_handle() api

* update format

* add unittests

* alter function name
XiaoguangHu01 pushed a commit that referenced this pull request Feb 25, 2021
* add get_cublas_handle() api

* update format

* add unittests

* alter function name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants