Skip to content

[CustomOp] Split build directory for each setup.py #31124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2021
Merged

[CustomOp] Split build directory for each setup.py #31124

merged 2 commits into from
Feb 24, 2021

Conversation

@Aurelius84
Copy link
Contributor

@Aurelius84 Aurelius84 commented Feb 22, 2021

PR types

New features

PR changes

Others

Describe

What's New?

Before this PR, all setup.py in unittests share same build directory, which will lead to remove the directory by mistake while parallelling execute setup.py, for example on CI.

So we split them into independent sub-directory, such as

// For setup build
-- build
  |-- custom_relu2
      |-- relu2.so
  |-- multi_outs
  |-- ....


// For /root/.cache/paddle_extension

-- paddle_extension
  |--custom_relu2
     |-- relu2.so
  |-- multi_outs
  |-- ...

@paddle-bot-old
Copy link

paddle-bot-old bot commented Feb 22, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

chalsliu
chalsliu previously approved these changes Feb 23, 2021
View reviewed changes
@Aurelius84 Aurelius84 requested a review from chalsliu February 24, 2021 02:04
chenwhql
chenwhql approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhwesky2010
zhwesky2010 approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 merged commit dce2db4 into PaddlePaddle:develop Feb 24, 2021
chenwhql pushed a commit to chenwhql/Paddle that referenced this pull request Feb 26, 2021
@Aurelius84 @chenwhql
[CustomOp] Split build directory for each setup.py (PaddlePaddle#31124)
fdb169b 
* split build directory for each setup.py

* fix template string
@Aurelius84 Aurelius84 deleted the fix_custom_op_ci branch April 12, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenwhql chenwhql chenwhql approved these changes

@chalsliu chalsliu chalsliu approved these changes

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

@zhhsplendid zhhsplendid Awaiting requested review from zhhsplendid

@JiabinYang JiabinYang Awaiting requested review from JiabinYang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Aurelius84 @chenwhql @chalsliu @zhwesky2010