[ROCM] update fluid collective op for rocm, test=develop #31075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
| void Compute(const framework::ExecutionContext &ctx) const override { | ||
| #if defined(PADDLE_WITH_NCCL) && NCCL_VERSION_CODE >= 2703 | ||
| #if (defined(PADDLE_WITH_RCCL) || defined(PADDLE_WITH_NCCL)) && \ | ||
| NCCL_VERSION_CODE >= 2703 |
Contributor
There was a problem hiding this comment.
RCCL里用的是NCCL_VERSION_CODE还是RCCL_VERSION_CODE
Contributor
There was a problem hiding this comment.
可以加个注释说明一下，RCCL用的也是NCCL_VERSION_CODE，除了名字不一样，其余的基本一致。
Contributor
Author
There was a problem hiding this comment.
RCCL里面用的也是NCCL_VERSION_CODE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
update fluid collective op for rocm