[CustomOp] Support to specific extra_cflags and exctra_cuda_flags independently #31059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
…into custom_op_flags
Aurelius84
requested review from
JiabinYang,
chenwhql,
zhhsplendid and
zhwesky2010
chenwhql
approved these changes
Feb 24, 2021
Contributor
chenwhql
left a comment
chenwhql
left a comment
There was a problem hiding this comment.
LGTM, can polish details in next PR
| name(str): generated shared library file name. | ||
| sources(list[str]): custom op source files name with .cc/.cu suffix. | ||
| extra_cflag(list[str]): additional flags used to compile CPP files. By default | ||
| extra_cxx_cflags(list[str]): additional flags used to compile CPP files. By default |
Contributor
There was a problem hiding this comment.
extra_cxx_cflags(list[str], optional), others same
| extra_include_paths=paddle_includes, # add for Coverage CI | ||
| extra_cflags=extra_compile_args, # add for Coverage CI | ||
| extra_cxx_cflags=extra_compile_args, | ||
| extra_cuda_cflags=extra_compile_args, # add for Coverage CI |
Contributor
There was a problem hiding this comment.
only cc test may not need extra_cuda_cflags
| extra_include_paths=paddle_includes, # add for Coverage CI | ||
| extra_cflags=extra_compile_args, # add for Coverage CI | ||
| extra_cxx_cflags=extra_compile_args, # add for Coverage CI | ||
| extra_cuda_cflags=extra_compile_args, # add for Coverage CI |
chenwhql
pushed a commit
to chenwhql/Paddle
that referenced
this pull request
Feb 26, 2021
…ependently (PaddlePaddle#31059) * split cxx/nvcc compile flags * enhance input argument check * rename extra_cflags into extrac_cxx_flags * add name checking in setup * fix test_dispatch failed * fix word typo and rm usless import statement * refine import statement * fix unittest failed * fix cuda flags error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
What's New?
extra_cflagsandexctra_cuda_flagsindependently.nameargument insetupAPI and not allow using"module"as suffix inname.