Skip to content

Fix the name error and exit caused by judgment failed #28118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2020
Merged

Fix the name error and exit caused by judgment failed #28118

merged 1 commit into from
Oct 20, 2020

Conversation

@Avin0323
Copy link
Contributor

@Avin0323 Avin0323 commented Oct 20, 2020

PR types

Others

PR changes

Others

Describe

  • Fix the name error, use vs_installer.exe instead of visual_installer.exe.
  • Test nvcc and java via cmd /C to avoid direct failure.
  • Add argument /E /Y /R for xcopy command to copy file silent.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Oct 20, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhwesky2010
zhwesky2010 approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit 80c5d23 into PaddlePaddle:develop Oct 20, 2020
@Avin0323 Avin0323 deleted the fix-win-build-compile-env-script branch October 20, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Avin0323 @zhwesky2010