Skip to content

[cherry-pick] Incorporate cudnn_lstm into LSTM api (#27217)#28023

Merged
guoshengCS merged 2 commits intoPaddlePaddle:release/2.0-rcfrom
guoshengCS:cherry-pick-cudnn-lstm
Oct 19, 2020
Merged

[cherry-pick] Incorporate cudnn_lstm into LSTM api (#27217)#28023
guoshengCS merged 2 commits intoPaddlePaddle:release/2.0-rcfrom
guoshengCS:cherry-pick-cudnn-lstm

Conversation

@guoshengCS
Copy link
Contributor

PR types

New features

PR changes

Others

Describe

[cherry-pick] Incorporate cudnn_lstm into LSTM api (#27217)

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

jzhang533
jzhang533 previously approved these changes Oct 16, 2020
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

zhangting2020
zhangting2020 previously approved these changes Oct 16, 2020
Copy link
Contributor

@zhangting2020 zhangting2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 previously approved these changes Oct 16, 2020
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

guoshengCS and others added 2 commits October 18, 2020 02:40
* Incorporate cudnn_lstm into LSTM api.
test=develop

* Make coalesce_tensor support alignment optionally.
test=develop

* Reorganize RNN apis. test=develop

* Fix cudnn rnn layout conversion.
test=develop

* Add sequence_length support for RNN cudnn implement.
Add optional init_h and init_c gradient for cudnn_lstm_op.
test=develop

* Use create_parameter for rnn cudnn impl.
test=develop

* Move `self._flat_weight = self.create_parameter()` in RNNBase to main_program.
test=develop

* Update RNN api unittest to use set_device.
test=develop

* Fix set_place for unit tests of RNN apis.
test=develop

* Fix use_align in coalesce_tensor_op.
test=develop

* Adjust RNN apis arguments according to comments.
test=develop

* Polish documents for SimpleRNN apis.
test=develop

* Refine random seed in cudnn_lstm_op.
Expose rnn params from sublayers to RNN.
test=develop

* Fix RNN saving for jit.save.
Refine cudnn_lstm dropout behavior.
test=develop

* Fix doc of GRU. test=develop

* Use ShareDataWith to avoid copying for cudnn_lstm_op test.
test=develop

* Remove updates on cudnn_lstm temporarily.
test=develop

* Use ShareDataWith to avoid copying for cudnn_lstm_op test.
test=develop

* Refine random seed in cudnn_lstm_op.
test=develop

* Fix test_lstm by adjust ConcreteProgram buffer getter.
test=develop

* Use create_parameter instead of create_var for rnn._flat_weight for static graph usage.
test=develop

* Remove W input for cudnn_lstm to pass unused_var_check.
test=develop

* Add test_predict for RNN unit tests coverage.
test=develop

* Fix code style of rnn.
test=develop

* Fix F.rnn usage in rnn.py.
test=develop
* fix test_lstm unittest failed

* add more unittest

* modify cmakelist

* fix judgement
@guoshengCS guoshengCS force-pushed the cherry-pick-cudnn-lstm branch from 62c37e6 to a9a731e Compare October 17, 2020 18:42
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Oct 18, 2020
@PaddlePaddle PaddlePaddle unlocked this conversation Oct 18, 2020
@zhiqiu zhiqiu self-requested a review October 19, 2020 02:22
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@guoshengCS guoshengCS merged commit 3f56590 into PaddlePaddle:release/2.0-rc Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants