Add batch_norm and layer_norm XPU kernels #27818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test=develop, test=kunlun
|
Thanks for your contribution! |
Contributor
Author
|
@QingshuChen 麻烦帮忙review下哈 |
hong19860320
commented
Oct 13, 2020
|
|
||
| def test_check_grad(self): | ||
| self.check_grad_with_place( | ||
| paddle.XPUPlace(0), ['X'], 'Y', max_relative_error=0.02) |
Contributor
Author
There was a problem hiding this comment.
如果修改为默认值，则单测无法通过，报如下错误：
| pass | ||
|
|
||
| def test_check_output(self): | ||
| self.check_output_with_place(paddle.XPUPlace(0), atol=1e-4) |
Contributor
Author
There was a problem hiding this comment.
如果修改为默认值，则单测无法通过，报如下错误：
| for id, name in enumerate(fetch_list): | ||
| self.assertEqual( | ||
| np.allclose( | ||
| outputs[name], outs[id], atol=1e-4), True) |
Contributor
Author
There was a problem hiding this comment.
如果使用默认值，则输出Y存在diff:
QingshuChen
reviewed
Oct 13, 2020
Contributor
QingshuChen
left a comment
QingshuChen
left a comment
There was a problem hiding this comment.
@QingshuChen 麻烦帮忙review下哈
LGTM
|
|
||
| def test_check_grad(self): | ||
| self.check_grad_with_place( | ||
| paddle.XPUPlace(0), ['X'], 'Y', max_relative_error=0.02) |
Contributor
Author
There was a problem hiding this comment.
不行的，超过了默认值0.005，具体可以见我的comments中的截图
Xreki
approved these changes
Oct 13, 2020
Contributor
Xreki
left a comment
Xreki
left a comment
There was a problem hiding this comment.
LGTM for the change of atol and max_relative_error.
kolinwei
approved these changes
Oct 13, 2020
chen-zhiyu
pushed a commit
to chen-zhiyu/Paddle
that referenced
this pull request
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
support batch_norm and layer_norm on Baidu Kunlun