Skip to content

Add avx512 core instructions check 2 #27750

Merged
luotao1 merged 2 commits intoPaddlePaddle:developfrom
wozna:bfloat16_check3
Oct 1, 2020
Merged

Add avx512 core instructions check 2 #27750
luotao1 merged 2 commits intoPaddlePaddle:developfrom
wozna:bfloat16_check3

Conversation

@wozna
Copy link

@wozna wozna commented Oct 1, 2020

PR types

Bug fixes

PR changes

OPs

Describe

In previous PR #27732 I added an instruction check but it only works while running from python, but it did not work if the test was run from cmake.
This PR adds unittest.SkipIf what skip the test if the place does not support bfloat16 evaluation and it works for both cases.

It also removes duplicated self.use_mkldnn = True

@paddle-bot-old
Copy link

paddle-bot-old bot commented Oct 1, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit a90711c into PaddlePaddle:develop Oct 1, 2020
@wozna wozna deleted the bfloat16_check3 branch February 24, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants