[bug fix] avoiding multiple initialization of gloo for fleet in dygraph mode#27706
Merged
guru4elephant merged 16 commits intoPaddlePaddle:developfrom Sep 30, 2020
Merged
Conversation
added 13 commits
September 8, 2020 08:54
|
Thanks for your contribution! |
added 3 commits
September 29, 2020 08:39
… gloo_dygraph_fleet_fix, test=develop
guru4elephant
approved these changes
Sep 30, 2020
Member
guru4elephant
left a comment
guru4elephant
left a comment
There was a problem hiding this comment.
LGTM, not a good design, but ok
| self._collective_env() | ||
| self._role_is_generated = True | ||
| self._gloo_init() | ||
| if not paddle.fluid.framework.in_dygraph_mode(): |
Member
There was a problem hiding this comment.
it seems in dygraph mode, we do not need to do gloo_init, but actually it is initialized in other places. In general, this is not a good design, and should be refactored with init_parallel_env in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
avoiding multiple initialization of gloo for fleet in dygraph mode