Skip to content

fix api name, english doc, unittest, and remove useless alias of 2.0 lr_scheduler #27686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 13, 2020
Merged

fix api name, english doc, unittest, and remove useless alias of 2.0 lr_scheduler #27686

merged 11 commits into from
Oct 13, 2020

Conversation

@zhwesky2010
Copy link
Contributor

@zhwesky2010 zhwesky2010 commented Sep 28, 2020 •
edited
Loading

PR types

New features

PR changes

APIs

Describe

image

image

image

@paddle-bot-old
Copy link

paddle-bot-old bot commented Sep 28, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhwesky2010 zhwesky2010 changed the title fix doc and unittest of 2.0 lr_scheduler fix english doc、unittest、remove useless alias of 2.0 lr_scheduler Sep 29, 2020
@zhwesky2010 zhwesky2010 changed the title fix english doc、unittest、remove useless alias of 2.0 lr_scheduler fix english doc, unittest, remove useless alias of 2.0 lr_scheduler Sep 29, 2020
@zhwesky2010 zhwesky2010 changed the title fix english doc, unittest, remove useless alias of 2.0 lr_scheduler fix english doc, unittest, and remove useless alias of 2.0 lr_scheduler Sep 29, 2020
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Sep 29, 2020
@PaddlePaddle PaddlePaddle unlocked this conversation Sep 29, 2020
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Sep 30, 2020
@PaddlePaddle PaddlePaddle unlocked this conversation Sep 30, 2020
@zhwesky2010 zhwesky2010 force-pushed the fix_lr_scheduler_2.0 branch 2 times, most recently from 3f7b738 to 8e9e055 Compare September 30, 2020 07:24
XiaoguangHu01
XiaoguangHu01 previously approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TCChenlong
TCChenlong reviewed Oct 12, 2020
View reviewed changes
python/paddle/optimizer/optimizer.py Outdated
Copy link
Contributor

@TCChenlong TCChenlong Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这行可以删除

python/paddle/optimizer/optimizer.py Outdated
Copy link
Contributor

@TCChenlong TCChenlong Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这行可以删除

python/paddle/optimizer/lr.py Outdated

This comment was marked as resolved.

Sign in to view

python/paddle/optimizer/lr.py Outdated

This comment was marked as resolved.

Sign in to view

python/paddle/optimizer/lr.py Outdated

This comment was marked as resolved.

Sign in to view

python/paddle/optimizer/lr.py Outdated

This comment was marked as resolved.

Sign in to view

python/paddle/optimizer/lr.py Outdated

This comment was marked as resolved.

Sign in to view

python/paddle/optimizer/lr.py Outdated

This comment was marked as resolved.

Sign in to view

python/paddle/optimizer/lr.py Outdated

This comment was marked as resolved.

Sign in to view

python/paddle/optimizer/optimizer.py Outdated
Copy link
Contributor

@TCChenlong TCChenlong Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这行可以删除

Copy link
Contributor Author

@zhwesky2010 zhwesky2010 Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Done

TCChenlong
TCChenlong approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

raindrops2sea
raindrops2sea approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@raindrops2sea raindrops2sea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhwesky2010 zhwesky2010 merged commit e122e16 into PaddlePaddle:develop Oct 13, 2020
chen-zhiyu pushed a commit to chen-zhiyu/Paddle that referenced this pull request Oct 15, 2020
@zhwesky2010 @chen-zhiyu
fix english doc, unittest, and remove useless alias of 2.0 lr_schedul…
96ad3f6 
…er (PaddlePaddle#27686)

* fix doc and unittest of 2.0 lr_scheduler

* fix doc of 2.0 lr_scheduler

* fix unittest

* fix english doc of lr_scheduler

* fix api name of lr scheduler

* fix api name of lr scheduler
@zhwesky2010 zhwesky2010 changed the title fix english doc, unittest, and remove useless alias of 2.0 lr_scheduler fix api name, english doc, unittest, and remove useless alias of 2.0 lr_scheduler Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TCChenlong TCChenlong TCChenlong approved these changes

@raindrops2sea raindrops2sea raindrops2sea approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhwesky2010 @TCChenlong @raindrops2sea @XiaoguangHu01