Skip to content

Pass op version.#27329

Merged
cryoco merged 2 commits intoPaddlePaddle:developfrom
shangzhizhou:pass_op_version
Sep 17, 2020
Merged

Pass op version.#27329
cryoco merged 2 commits intoPaddlePaddle:developfrom
shangzhizhou:pass_op_version

Conversation

@shangzhizhou
Copy link
Member

PR types

Others

PR changes

Others

Describe

Pass添加op的版本检查,列表如下:

pass文件 是否兼容 处理措施 备注
skip_layernorm_fuse_pass.cc 不完善 注册 ernie定制fuse,只支持动态shape,后续试需求增加静态shape实现
embedding_eltwise_layernorm_fuse_pass.cc 不完善 注册 ernie定制fuse,只支持动态shape,后续试需求增加静态shape实现
multihead_matmul_fuse_pass.cc 不完善 注册 ernie定制fuse,只支持动态shape,后续试需求增加静态shape实现
conv_bias_mkldnn_fuse_pass.cc 不兼容 部分修复;添加单测;注册 conv2d不支持dilation属性,添加判断逻辑放弃融合;conv3d、conv2d_transpose单测出错,已转军才反馈Intel;
conv_elementwise_add_mkldnn_fuse_pass.cc x x 会被conv_bias_mkldnn_fuse_pass优先命中
conv_relu_mkldnn_fuse_pass.cc x x pass已经迁移至conv_activation_mkldnn_fuse_pass.cc
cpu_quantize_pass.cc x x 量化离线工具quant2_int8_mkldnn_pass.py使用
cpu_quantize_placement_pass.cc x x MKLDNN离线量化使用,当前不再使用,推荐使用paddleslim离线量化
cpu_quantize_squash_pass.cc x x 量化离线工具quant2_int8_mkldnn_pass.py使用
depthwise_conv_mkldnn_pass.cc 兼容 已注册 该pass将depthwise_conv2d转化为conv2d,后续有其他conv2d相关的fuse pass处理
mkldnn_placement_pass.cc x x 此pass不做融合,只是标记op是否支持mkldnn,具体的op融合在后续其他pass中,如果此处检查op的attribute,需要检查所有mkldnn支持的op,且和op的实际使用位置分离,不利于后续维护。

@shangzhizhou shangzhizhou changed the title Pass op version Pass op version. Sep 16, 2020
@lidanqing-vv
Copy link
Contributor

@jczaja @wojtuss It seems there is some update plan of pass op version

Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cryoco cryoco merged commit 3c11717 into PaddlePaddle:develop Sep 17, 2020
@shangzhizhou shangzhizhou deleted the pass_op_version branch September 18, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants