Skip to content

fix cross_entropy bug of the axis parameter in log_softmax #27311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shippingwang merged 2 commits into from
Sep 18, 2020
Merged

fix cross_entropy bug of the axis parameter in log_softmax #27311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e328b36
fix the axis param of log_softmax in cross_entropy
chajchaj Sep 15, 2020
f8dda75
change the default value of log_softmax's parameter axis in test_cros…
chajchaj Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/paddle/fluid/tests/unittests/test_cross_entropy_loss.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def stable_softmax(x):
return exps / np.sum(exps)


def log_softmax(x, axis=-1):
def log_softmax(x, axis=1):
softmax_out = np.apply_along_axis(stable_softmax, axis, x)
return np.log(softmax_out)

Expand Down
2 changes: 1 addition & 1 deletion python/paddle/nn/functional/loss.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1102,7 +1102,7 @@ def cross_entropy(input,
" 'none', but received %s, which is not allowed." % reduction)

#step 1. log_softmax
log_softmax_out = paddle.nn.functional.log_softmax(input)
log_softmax_out = paddle.nn.functional.log_softmax(input, axis=1)
if weight is not None and not isinstance(weight, Variable):
raise ValueError(
"The weight' is not a Variable, please convert to Variable.")
Expand Down