Add 3 pass version check#27283
Merged
DannyIsFunny merged 3 commits intoPaddlePaddle:developfrom Sep 18, 2020
Merged
Conversation
|
Thanks for your contribution! |
test=develop
haozech
force-pushed
the
pass_version_develop
branch
from
b43e3ce to
cffe340
Compare
Contributor
Author
Member
shangzhizhou
left a comment
shangzhizhou
left a comment
There was a problem hiding this comment.
在确认op属性都支持的情况下，请在单测中添加版本检测用例，可参考卫波已合入PR
test=develop
| if core.is_compiled_with_cuda(): | ||
| use_gpu = True | ||
| self.check_output_with_option(use_gpu) | ||
| PassVersionChecker.IsCompatible('conv_elementwise_add2_act_fuse_pass') |
Member
There was a problem hiding this comment.
需要添加返回值断言
self.assertTrue(...)
| if core.is_compiled_with_cuda(): | ||
| use_gpu = True | ||
| self.check_output_with_option(use_gpu) | ||
| PassVersionChecker.IsCompatible('conv_elementwise_add_act_fuse_pass') |
| if core.is_compiled_with_cuda(): | ||
| use_gpu = True | ||
| self.check_output_with_option(use_gpu) | ||
| PassVersionChecker.IsCompatible('conv_elementwise_add_fuse_pass') |
Contributor
Author
|
@Superjomn 辛苦review下 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
Add three passes' version check