Skip to content

fix the localsgd optimizer #27094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ForFishes merged 3 commits into from
Sep 7, 2020
Merged

fix the localsgd optimizer #27094

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59cea39
fix the localsgd
ForFishes Sep 6, 2020
d9bf1a4
fix sgd
ForFishes Sep 6, 2020
5412f46
fix the bug of localsgd
ForFishes Sep 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions python/paddle/distributed/fleet/meta_optimizers/localsgd_optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@

from __future__ import print_function

import paddle
from paddle.fluid import program_guard, layers, default_main_program
from paddle.fluid.optimizer import Momentum, SGD
from .meta_optimizer_base import MetaOptimizerBase
from .common import OpRole, OP_ROLE_KEY, CollectiveHelper, is_update_op

Expand All @@ -35,8 +35,10 @@ def _can_apply(self):
if self.role_maker.worker_num() <= 1:
return False

return isinstance(self.inner_opt, Momentum) \
or isinstance(self.inner_opt, SGD)
return isinstance(self.inner_opt, paddle.optimizer.momentum.Momentum) \
or isinstance(self.inner_opt, paddle.fluid.optimizer.Momentum) \
or isinstance(self.inner_opt, paddle.optimizer.sgd.SGD) \
or isinstance(self.inner_opt, paddle.fluid.optimizer.SGD)

def _disable_strategy(self, dist_strategy):
dist_strategy.localsgd = False
Expand Down