Skip to content

revert the div/floordiv/remainder#26975

Closed
ForFishes wants to merge 1 commit intoPaddlePaddle:developfrom
ForFishes:revert_div
Closed

revert the div/floordiv/remainder#26975
ForFishes wants to merge 1 commit intoPaddlePaddle:developfrom
ForFishes:revert_div

Conversation

@ForFishes
Copy link
Member

PR types

Others

PR changes

APIs

Describe

The division series (/, //, %) have been integrated before. If division is used in the while_loop, and it is Tensor and scalar, an error will be reported. I need to revert back now PR:#26562

@paddle-bot-old
Copy link

paddle-bot-old bot commented Sep 3, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiqiu zhiqiu self-requested a review September 7, 2020 07:04
@ForFishes ForFishes closed this Sep 14, 2020
@ForFishes ForFishes deleted the revert_div branch December 7, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants