Skip to content

gather_nd Op refine#26540

Merged
wangchaochaohu merged 6 commits intoPaddlePaddle:developfrom
wangchaochaohu:gather_nd
Aug 23, 2020
Merged

gather_nd Op refine#26540
wangchaochaohu merged 6 commits intoPaddlePaddle:developfrom
wangchaochaohu:gather_nd

Conversation

@wangchaochaohu
Copy link
Contributor

@wangchaochaohu wangchaochaohu commented Aug 21, 2020

PR types

Function optimization

PR changes

APIs

Describe

refine the paddle.gather_nd

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 21, 2020

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@wangchaochaohu wangchaochaohu changed the title refine the code gather_nd Op refine Aug 21, 2020
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

Its dtype should be int32, int64.
name (str|None): A name for this layer(optional). If set None, the
layer will be named automatically.
input (Tensor): The source input. Its dtype should be bool, float32, float64, int32, int64.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fluid.layers.gather_nd 补充一个deprecated标记,记录API之间的对应关系。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#26579 已加

.. code-block:: text

Given:
input = [[[ 0, 1, 2, 3],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

input -> x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#26579 done

Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangchaochaohu wangchaochaohu merged commit 9219b79 into PaddlePaddle:develop Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants