Skip to content

Conversation

@Thunderbrook
Copy link
Contributor

@Thunderbrook Thunderbrook commented Aug 7, 2020

PR types

Bug fixes

PR changes

Others

Describe

cherry-pick fix dataset py3 #25012
cherry-pick fixlogger #24682
cherry-pick add timeout of gloo #23436
cherry-pick modify datanorm op #23030

* fix dataset py3 error
* test=develop
@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 7, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 7, 2020

✅ This PR's description meets the template requirements!
Please wait for other CI results.

xjqbest and others added 3 commits August 7, 2020 19:35
* fix logger of FetchHandler,which may print log twice
* test=develop
* add timeout and http store in communication, add revert and confirm in fleet
* test=develop
@Thunderbrook Thunderbrook changed the title fix dataset py3 (#25012) cherry-pick fix dataset py3; fixlogger; add timeout of gloo; modify datanorm op Aug 10, 2020
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for unused_var_check.cc

Copy link
Contributor

@swtkiwi swtkiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@raindrops2sea raindrops2sea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Thunderbrook Thunderbrook merged commit e8d5868 into PaddlePaddle:release/1.8 Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants