Fix unit test error: File exists: '/root/.cache/paddle/dataset'#2536
Merged
helinwang merged 1 commit intoPaddlePaddle:developfrom Jun 20, 2017
Merged
Fix unit test error: File exists: '/root/.cache/paddle/dataset'#2536helinwang merged 1 commit intoPaddlePaddle:developfrom
helinwang merged 1 commit intoPaddlePaddle:developfrom
Conversation
emailweixu
approved these changes
Jun 20, 2017
wangkuiyi
reviewed
Jun 21, 2017
| try: | ||
| os.makedirs(DATA_HOME) | ||
| except OSError as exc: | ||
| if exc.errno != errno.EEXIST: |
Collaborator
There was a problem hiding this comment.
I don't get it -- it seems that we create DATA_HOME only if it doesn't exist; why would we need to catch the EEXIST exception here?
Contributor
Author
There was a problem hiding this comment.
Because ctest runs multiple python process concurrently, so this could happen.
Collaborator
There was a problem hiding this comment.
Does this mean that we can remove the check for existence in L30 and just run the try block?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2535