use IndexList to improve performance of instance_norm op#25132
Merged
zhangting2020 merged 3 commits intoPaddlePaddle:developfrom Oct 12, 2020
Merged
use IndexList to improve performance of instance_norm op#25132zhangting2020 merged 3 commits intoPaddlePaddle:developfrom
zhangting2020 merged 3 commits intoPaddlePaddle:developfrom
Conversation
|
Thanks for your contribution! |
luotao1
reviewed
Jun 19, 2020
Contributor
There was a problem hiding this comment.
If the compiler is older
多老的编译器?比如gcc4.8能否支持呢?
Contributor
Author
There was a problem hiding this comment.
目前由于windows上eigen版本未升级,因此直接替换为IndexList会导致编译错误。待windows也升级了eigen后,可以直接使用IndexList
0236da2 to
ef2d950
Compare
2dddb65 to
662ee4a
Compare
662ee4a to
572f972
Compare
chen-zhiyu
pushed a commit
to chen-zhiyu/Paddle
that referenced
this pull request
Oct 15, 2020
…e#25132) * use IndexList to improve performance, test=develop * remove EIGEN_HAS_INDEX_LIST, test=develop * use IndexList only when EIGEN_HAS_INDEX_LIST is true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimizationPR changes
OPsDescribe
IndexList in Eigen is used to encode a set of Tensor dimensions/indices. The indices in the list can be known at compile time or at runtime. A mix of static and dynamic indices can also be provided if needed. The tensor code will attempt to take advantage of the indices that are known at compile time to optimize the code it generates. Using IndexList instead of arrays of indices can speed up CPU and GPU performance.
Note:
EIGEN_HAS_INDEX_LISTis used in the code.Performance
CPU: