Add crop layers for supporting FCN model by wanghaoshuang · Pull Request #2490 · PaddlePaddle/Paddle

wanghaoshuang · 2017-06-16T11:17:52Z

qingqing01 · 2017-06-19T02:35:49Z

Cropping and Padding are the opposite operations. Can we use the padding function for this cropping operation?

wanghaoshuang · 2017-06-20T08:35:17Z

@qingqing01 @pkuyym padding function and cropping funtion is not opposite operations, strictly?
Padding forward funtion pad zero(or other values) to output tensor, while cropping backward function won`t change marginal element of output tensor.

'Padding forward funtion' != 'Cropping backward function'

wanghaoshuang · 2017-06-20T09:43:14Z

@qingqing01 @pkuyym Thks for interpretion and discussion about cropping function and padding function. I think i got it. Padding function and cropping funtion is opposite operations.
Using the padding function in crop layer make code clean, but confusing. Maybe the best solution is putting computaion code into tensor library.
So, shall we keep the current code structure?

qingqing01

This doc shows how to write a new layer. This code also needs the following contents.

Gradient check unit test in test_LayerGrad.
Python wrapper in config_parser.py
Python wrapper in trainer_config_helpers and its unit test.

qingqing01 · 2017-06-20T10:42:36Z

proto/ModelConfig.proto

Both Caffe and MXNet use offset to indicate crop_corner.

Thx，get it.

qingqing01 · 2017-06-20T10:49:05Z

paddle/gserver/layers/CropLayer.cpp

This layer should be able to accept two inputs, get the height and width from the second input. So, we can support to accept one or two inputs.

@qingqing01 I have submit a pr to add python wrapper and grad test for crop layer. But TeamCity build job was blocked by issue #2490

qingqing01 · 2017-06-27T11:46:40Z

@wanghaoshuang 如果提交了comments，请回复下哈~

1. change configure content to 'axis, offset, shape' 2. add an optional input to crop layer as cropping reference

…into crop_layer

… crop_layer

qingqing01

可以参考这个写个Python接口单测：https://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/trainer_config_helpers/tests/configs/test_pad.py

qingqing01 · 2017-07-17T12:34:53Z

python/paddle/trainer_config_helpers/layers.py

+    """
+    if isinstance(input, LayerOutput):
+        input = [input]
+    elif isinstance(input, Projection):


不支持Projection 输入，应该去掉。

qingqing01 · 2017-07-17T12:35:39Z

python/paddle/trainer_config_helpers/layers.py

+
+@wrap_name_default()
+@layer_support()
+def crop_layer(input, axis, offset, shape=None, name=None, layer_attr=None):


axis给个默认值吧。

qingqing01 · 2017-07-17T12:36:03Z

python/paddle/trainer_config_helpers/layers.py

+    :param offset: The crop offset
+    :type offset: Sequence
+    :param shape: The shape to be cropped. Default is None.
+    :type shape: Sqquence | None


Sqquence是啥？

Fixed. Sqquence->Sequence

qingqing01 · 2017-07-17T12:36:39Z

python/paddle/trainer_config_helpers/layers.py

+@layer_support()
+def crop_layer(input, axis, offset, shape=None, name=None, layer_attr=None):
+    """
+    The crop layer crop images by offset and shape. User can set crop shape by


The crop layer crop -> The crop layer crops

qingqing01 · 2017-07-17T12:40:26Z

paddle/gserver/layers/CropLayer.cpp

+  inDims_.setDim(0, batchSize);
+  int h = inputLayers_[0]->getOutput().getFrameHeight();
+  if (h != 0) inDims_.setDim(2, h);
+  int w = inputLayers_[0]->getOutput().getFrameWidth();


应该是：inputLayers_[1]？看Python接口里，第2个input是reference_input

这里是取原始input的dims，所以是inputLayers_[0].

qingqing01 · 2017-07-17T12:47:31Z

paddle/gserver/layers/CropLayer.cpp

+}
+
+void CropLayer::setTensorDim(const size_t batchSize) {
+  CHECK_EQ(static_cast<int>(inputLayers_.size()), 2);


Python接口写的是支持一个或两个输入，这块却是CHECK_EQ ?

2. Add crop layer unitest 3. Fix bugs

… crop_layer

…into crop_layer

wanghaoshuang · 2017-07-19T07:54:55Z

@qingqing01 crop layer相关bugs已经fixed.已commit.

qingqing01 requested changes Jun 20, 2017

View reviewed changes

wanghaoshuang force-pushed the crop_layer branch from f9c7e96 to e31ccd6 Compare June 22, 2017 09:04

wanghaoshuang force-pushed the crop_layer branch from 88b432e to a5c4d06 Compare July 4, 2017 16:58

wanghaoshuang added 4 commits July 5, 2017 10:37

add crop layer

013d0a2

Refine configure option of crop layer

90ed200

1. change configure content to 'axis, offset, shape' 2. add an optional input to crop layer as cropping reference

Add grad test and python wrapper for crop layer

701827f

fix crop function test

cbd61c7

wanghaoshuang force-pushed the crop_layer branch from a5c4d06 to cbd61c7 Compare July 5, 2017 02:38

wanghaoshuang added 11 commits July 5, 2017 11:35

add crop layer

e10040c

Refine configure option of crop layer

d1d70ec

1. change configure content to 'axis, offset, shape' 2. add an optional input to crop layer as cropping reference

Add grad test and python wrapper for crop layer

5e6e1f6

fix crop function test

86bdb2f

fix unittest of crop layer

cf86891

Merge branch 'crop_layer' of https://github.com/wanghaoshuang/Paddle …

470af1d

…into crop_layer

fix cpp format

acfd2fc

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

d378e0a

… crop_layer

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

0b788ef

… crop_layer

fix crop layer python wrapper bug

69b1222

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

de5ded6

… crop_layer

qingqing01 reviewed Jul 17, 2017

View reviewed changes

wanghaoshuang added 4 commits July 19, 2017 13:47

1. Reading image shape from input data instead of image_config

3e7819c

2. Add crop layer unitest 3. Fix bugs

Merge branch 'develop' into crop_layer

d83bae8

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

60a7889

… crop_layer

Merge branch 'crop_layer' of https://github.com/wanghaoshuang/Paddle …

2e58f2c

…into crop_layer

fix cmake

676b76d

qingqing01 approved these changes Jul 19, 2017

View reviewed changes

wanghaoshuang merged commit 2e2a674 into PaddlePaddle:develop Jul 19, 2017

wanghaoshuang changed the title ~~add crop layer~~ Add layers for supporting FCN model Aug 11, 2017

wanghaoshuang changed the title ~~Add layers for supporting FCN model~~ Add crop layers for supporting FCN model Aug 11, 2017

wanghaoshuang deleted the crop_layer branch May 20, 2022 03:59

chen2016013 pushed a commit to chen2016013/Paddle that referenced this pull request Oct 17, 2025

support ci which download models from hugging face (PaddlePaddle#2490)

495645b

Comments

Conversation

wanghaoshuang commented Jun 16, 2017

Uh oh!

qingqing01 commented Jun 19, 2017

Uh oh!

wanghaoshuang commented Jun 20, 2017

Uh oh!

wanghaoshuang commented Jun 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qingqing01 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qingqing01 Jun 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wanghaoshuang Jul 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qingqing01 commented Jun 27, 2017

Uh oh!

qingqing01 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wanghaoshuang commented Jul 19, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

wanghaoshuang commented Jun 20, 2017 •

edited

Loading

qingqing01 left a comment •

edited

Loading

qingqing01 Jun 20, 2017 •

edited

Loading

wanghaoshuang Jul 5, 2017 •

edited

Loading