Skip to content

update the SRL demo. #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 17, 2017
Merged

update the SRL demo. #2178

merged 3 commits into from
May 17, 2017

Conversation

@lcy-seso
Copy link
Contributor

@lcy-seso lcy-seso commented May 17, 2017

fix #1788. fix #2080.

  1. add v2 inferring to SRL demo.
  2. inferring over the entire batch.
  3. inferring by load the parameter only once to speed up.

@lcy-seso lcy-seso requested a review from qingqing01 May 17, 2017 07:40
@lcy-seso
Copy link
Contributor Author

lcy-seso commented May 17, 2017

  • I use model saved by the first pass and test the entire test set which contains 5267 samples.
  • To avoid loading the parameters in every tested batch, the inferring time is reduced from 96.5s to 78.19s.

qingqing01
qingqing01 reviewed May 17, 2017
View reviewed changes
demo/semantic_role_labeling/api_train_v2.py Outdated
import paddle.v2 as paddle

logger = logging.getLogger('paddle')
logger.setLevel(logging.WARN)
Copy link
Contributor

@qingqing01 qingqing01 May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下面的print是不是也可以统一用logger?

Copy link
Contributor Author

@lcy-seso lcy-seso May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

demo/semantic_role_labeling/api_train_v2.py Outdated
result = trainer.test(reader=reader, feeding=feeding)
print "\nTest with Pass %d, %s" % (event.pass_id, result.metrics)

if not is_predict:
Copy link
Contributor

@qingqing01 qingqing01 May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if else分支，建议改成两个函数train和infer。trainer = paddle.trainer.SGD 和 reader等也不属于infer分支~

Copy link
Contributor Author

@lcy-seso lcy-seso May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@lcy-seso lcy-seso merged commit 83c24ff into PaddlePaddle:develop May 17, 2017
@lcy-seso lcy-seso deleted the update_srl_demo branch May 25, 2017 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qingqing01 qingqing01 qingqing01 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@lcy-seso @qingqing01