Skip to content

add assert when is_seq=True, there must be a bootLayer in the network #2161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 17, 2017
Merged

add assert when is_seq=True, there must be a bootLayer in the network #2161

merged 2 commits into from
May 17, 2017

Conversation

@luotao1
Copy link
Contributor

@luotao1 luotao1 commented May 16, 2017

fix #2142

@luotao1 luotao1 requested review from lcy-seso and xinghai-sun May 16, 2017 08:42
@wangkuiyi wangkuiyi changed the title add assert when is_seq=True, there must be bootLayer add assert when is_seq=True, there must be a bootLayer in the network May 16, 2017
lcy-seso
lcy-seso requested changes May 17, 2017
View reviewed changes
Copy link
Contributor

@lcy-seso lcy-seso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small modification.

python/paddle/trainer_config_helpers/layers.py Outdated
Copy link
Contributor

@lcy-seso lcy-seso May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是不是可以直接改在 config_parser.py里面，这样不论是使用v0，v1，v2的用户都能报错误。

Copy link
Contributor Author

@luotao1 luotao1 May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

lcy-seso
lcy-seso approved these changes May 17, 2017
View reviewed changes
Copy link
Contributor

@lcy-seso lcy-seso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcy-seso lcy-seso merged commit 39b9112 into PaddlePaddle:develop May 17, 2017
@luotao1 luotao1 deleted the memory branch June 5, 2017 04:33
heavengate pushed a commit to heavengate/Paddle that referenced this pull request Aug 16, 2021
@wangxinxin08
fix bias problem while training (PaddlePaddle#2161)
524f56f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcy-seso lcy-seso lcy-seso approved these changes

@xinghai-sun xinghai-sun Awaiting requested review from xinghai-sun

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mandatory boot_layer argument in paddle.layer.memory if is_seq set True.

2 participants

@luotao1 @lcy-seso