add param_attr to nce_layer and enable multiple inputs. #2134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please add unit test in |
luotao1
reviewed
May 15, 2017
| input = [input] | ||
| assert not isinstance(param_attr, collections.Sequence) | ||
| param_attr = [param_attr] | ||
| else: |
Contributor
There was a problem hiding this comment.
please add simple usage in annotation when input is not LayerOutput, i.e, add simple usage for else branch.
lcy-seso
force-pushed
the
add_param_attr_to_nce
branch
from
b001077 to
c27a4ca
Compare
lcy-seso
force-pushed
the
add_param_attr_to_nce
branch
from
c27a4ca to
7556cef
Compare
qingqing01
approved these changes
May 15, 2017
lcy-seso
commented
May 15, 2017
Contributor
Author
lcy-seso
left a comment
lcy-seso
left a comment
There was a problem hiding this comment.
follow comments.
| input = [input] | ||
| assert not isinstance(param_attr, collections.Sequence) | ||
| param_attr = [param_attr] | ||
| else: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add param_attr to the nce_layer and enable multiple inputs.