supports multiple NCCL communicators preserved in NCCLCommContext#19407
Merged
gavin1332 merged 2 commits intoPaddlePaddle:developfrom Aug 27, 2019
Merged
supports multiple NCCL communicators preserved in NCCLCommContext#19407gavin1332 merged 2 commits intoPaddlePaddle:developfrom
gavin1332 merged 2 commits intoPaddlePaddle:developfrom
Conversation
gavin1332
force-pushed
the
nccl
branch
3 times, most recently
from
3b4298b to
a802018
Compare
…blem test=develop
hutuxian
approved these changes
Aug 27, 2019
| ring_id); | ||
| return comm_map_.at(ring_id).get(); | ||
| PADDLE_ENFORCE_GT(comm_map_.count(ring_id), 0, | ||
| "comunicator in ring id %d has not been initialized", |
Contributor
There was a problem hiding this comment.
comunicator -> communicator
Collaborator
Author
There was a problem hiding this comment.
leave it to TODO list
| } | ||
|
|
||
| // retrieve a communicator by the ring id and place | ||
| NCCLComm* Get(int ring_id, Place place) const { |
Collaborator
Author
There was a problem hiding this comment.
the place is a POD, not necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supports multiple NCCL communicators preserved in NCCLCommContext.
This pr adapt paddle pipeline training for single-process-and-multiple-threads training
test=develop