Change to use brpc rdma branch instead of personal branch.#18683
Merged
gongweibao merged 2 commits intoPaddlePaddle:developfrom Jul 19, 2019
Merged
Change to use brpc rdma branch instead of personal branch.#18683gongweibao merged 2 commits intoPaddlePaddle:developfrom
gongweibao merged 2 commits intoPaddlePaddle:developfrom
Conversation
luotao1
reviewed
Jul 18, 2019
cmake/external/brpc.cmake
Outdated
| @@ -40,8 +40,8 @@ ExternalProject_Add( | |||
| extern_brpc | |||
| ${EXTERNAL_PROJECT_LOG_ARGS} | |||
| # TODO(gongwb): change to de newst repo when they changed. | |||
Contributor
There was a problem hiding this comment.
Could you remove the TODO here? Since this TODO is finished in this PR.
luotao1
approved these changes
Jul 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the past, we use a personal brpc branch, and it's not allowed. So change it to the original rdma branch.