[MKL-DNN] Extended LRN with reusing via Acquire API#18675
Merged
luotao1 merged 1 commit intoPaddlePaddle:developfrom Jul 23, 2019
Merged
[MKL-DNN] Extended LRN with reusing via Acquire API#18675luotao1 merged 1 commit intoPaddlePaddle:developfrom
luotao1 merged 1 commit intoPaddlePaddle:developfrom
Conversation
Sand3r-
reviewed
Jul 22, 2019
test=develop - compileation fix - Yet another compilation fix - Even yet another compilation fix - Surprise! Again compilation fix - lint fixes test=develop - Fix to workspace acquire of LRN test=develop - Fix to hash of BWD LRN test=develop - fix to lrn BWD PD acquire test=develop - Fixing LRN PD creation test=develop - cosmetic fix in comment test=develop - Fixes after review test=develop
Contributor
Author
|
@luotao1 Could you please review this PR? Again your approval is needed to have CI passed |
Contributor
|
I test Google Net v1 (model with LRN) inference via CAPI with bs=1 on AVX2 platform e.g. E5-2650 v4. lrn from 241ms to 208ms, speedup 13%
|
Contributor
Is this Op-level speedup or Model-level speedup? @jczaja |
Contributor
Author
|
@luotao1 Reported speedup is on model level (SKX 8180 AVX512). I stored only partial log: before: ... After: .... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes discussed here are reimplementing LRN mkl-dnn ops to use common Acquire API .
Benefits: