Skip to content

delete AllocatorFacade destructor #18606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seiriosPlus merged 2 commits into from
Jul 12, 2019
Merged

delete AllocatorFacade destructor #18606

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed8d8dc
delete m, test=develop
seiriosPlus Jul 12, 2019
5239f13
delete m, test=develop
seiriosPlus Jul 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion paddle/fluid/memory/allocation/allocator_facade.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,9 @@ class AllocatorFacadePrivate {

// Pimpl. Make interface clean.
AllocatorFacade::AllocatorFacade() : m_(new AllocatorFacadePrivate()) {}
AllocatorFacade::~AllocatorFacade() { delete m_; }
// delete m_ may cause core dump when the destructor of python in conflict with
// cpp.
AllocatorFacade::~AllocatorFacade() {}
Copy link
Collaborator

@sneaxiy sneaxiy Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some comments on the reason why we remove delete m_.

Copy link
Collaborator Author

@seiriosPlus seiriosPlus Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


AllocatorFacade& AllocatorFacade::Instance() {
static AllocatorFacade instance;
Expand Down