Disable MKLDNN FC in Resnet50 test#18030
Merged
luotao1 merged 5 commits intoPaddlePaddle:developfrom Jun 13, 2019
Merged
Conversation
test=develop
luotao1
reviewed
Jun 12, 2019
|
|
||
| # resnet50 | ||
| inference_analysis_api_test_with_fake_data(test_analyzer_resnet50 | ||
| "${INFERENCE_DEMO_INSTALL_DIR}/resnet50" analyzer_resnet50_tester.cc "resnet50_model.tar.gz" true) |
Contributor
There was a problem hiding this comment.
Maybe set true-> false is enough?
Contributor
Author
There was a problem hiding this comment.
This flag is a huge workaround anyway, personally I don't believe we should use it at all, since MKL team has mentioned that its an undocumented feature and may disappear anytime. That's why I have removed it.
wojtuss
suggested changes
Jun 12, 2019
test=develop
Sand3r-
force-pushed
the
mgallus/disable-fc-mkldnn
branch
from
6795b56 to
f6e8abb
Compare
wojtuss
previously approved these changes
Jun 12, 2019
Contributor
why it fails on MAC? |
ghost
reviewed
Jun 12, 2019
| EXTRA_DEPS ${INFERENCE_EXTRA_DEPS} | ||
| ARGS --infer_model=${install_dir}/model) | ||
| ARGS --infer_model=${install_dir}/model | ||
| --disable_mkldnn_fc=disable_fc) |
There was a problem hiding this comment.
should be changed to "--disable_mkldnn_fc=${disable_fc}". This cause CI failure (on MAC).
Fix CI failure on MAC. Change "--disable_mkldnn_fc=disable_fc" to "--disable_mkldnn_fc=${disable_fc}"
ghost
dismissed
test=develop
wojtuss
pushed a commit
to wojtuss/Paddle
that referenced
this pull request
Jun 13, 2019
Added unit test for QAT FP32 & INT8 comparison (PaddlePaddle#17814) Disable MKLDNN FC in Resnet50 test (PaddlePaddle#18030) test=release/1.5
guru4elephant
pushed a commit
to guru4elephant/Paddle
that referenced
this pull request
Jun 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
temporary fix #18005