Skip to content

Cherry-pick: fix random CI failure.#18011

Merged
zhhsplendid merged 4 commits intoPaddlePaddle:developfrom
zhhsplendid:data_download_py3_develop
Jun 12, 2019
Merged

Cherry-pick: fix random CI failure.#18011
zhhsplendid merged 4 commits intoPaddlePaddle:developfrom
zhhsplendid:data_download_py3_develop

Conversation

@zhhsplendid
Copy link
Member

In some tests, SWEs used "print('xxx').format('xxx')". The syntax
is only supported in Python2, not python3. However, since those
lines are related to data download, if the CI machines already have
the data, it passes CI tests. That causes random failure.

Also temporary disable a unit test. The test will be fixed under high priority.

chengduo and others added 4 commits June 11, 2019 10:11
In some tests, SWEs used "print('xxx').format('xxx')". The syntax
is only supported in Python2, not python3. However, since those
lines are related to data download, if the CI machines already have
the data, it passes CI tests. That causes random failure.
@zhhsplendid zhhsplendid requested a review from sneaxiy June 12, 2019 02:40
Copy link
Collaborator

@sneaxiy sneaxiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhhsplendid zhhsplendid merged commit 0bf2535 into PaddlePaddle:develop Jun 12, 2019
@zhhsplendid zhhsplendid deleted the data_download_py3_develop branch June 18, 2019 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants