Newly added monitoring of python/requirements.txt file#17957
Merged
luotao1 merged 1 commit intoPaddlePaddle:developfrom Jun 11, 2019
tianshuo78520a:add_lujun_approval
Merged
Newly added monitoring of python/requirements.txt file#17957luotao1 merged 1 commit intoPaddlePaddle:developfrom tianshuo78520a:add_lujun_approval
luotao1 merged 1 commit intoPaddlePaddle:developfrom
tianshuo78520a:add_lujun_approval
Conversation
luotao1
reviewed
Jun 10, 2019
| APPROVALS=`curl -H "Authorization: token ${GITHUB_API_TOKEN}" https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${GIT_PR_ID}/reviews?per_page=10000 | \ | ||
| python ${PADDLE_ROOT}/tools/check_pr_approval.py 1 50069408` | ||
| elif [ "${API_FILE}" == "python/requirements.txt" ];then | ||
| APPROVALS=`curl -H "Authorization: token ${GITHUB_API_TOKEN}" https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${GIT_PR_ID}/reviews?per_page=10000 | \ |
Contributor
There was a problem hiding this comment.
curl -H "Authorization: token ${GITHUB_API_TOKEN}" https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${GIT_PR_ID}/reviews?per_page=10000 这句能复用下么？每个条件分支里都有。
Contributor
There was a problem hiding this comment.
或者加上python ${PADDLE_ROOT}/tools/check_pr_approval.py能一起复用么？优化后的命令类似：
xxx_function 1 3124479
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
添加监控python/requirements.txt文件，修改python/requirements.txt文件需要lujun315审核。