Skip to content

Fix/program doc#17908

Merged
JiabinYang merged 9 commits intoPaddlePaddle:developfrom
JiabinYang:fix/Program_doc
Jun 28, 2019
Merged

Fix/program doc#17908
JiabinYang merged 9 commits intoPaddlePaddle:developfrom
JiabinYang:fix/Program_doc

Conversation

@JiabinYang
Copy link
Contributor

@JiabinYang JiabinYang commented Jun 6, 2019

This PR add some comment for fluid.Program.clone()

@JiabinYang JiabinYang requested a review from shanyi15 June 6, 2019 14:46
@JiabinYang JiabinYang closed this Jun 12, 2019
@JiabinYang JiabinYang reopened this Jun 12, 2019
chengduoZH
chengduoZH previously approved these changes Jun 21, 2019
@@ -2756,6 +2756,15 @@ class Program(object):
it will contains nested block.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contains->contain

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed, but these are not related to my PR

@@ -2756,6 +2756,15 @@ class Program(object):
it will contains nested block.
Please reference the framework.proto for details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reference->refer to

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed, but these are not related to my PR

Copy link
Contributor

@xsrobin xsrobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as comments

Copy link
Contributor

@chengduoZH chengduoZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiabinYang JiabinYang merged commit 43f64a1 into PaddlePaddle:develop Jun 28, 2019
@JiabinYang JiabinYang deleted the fix/Program_doc branch January 14, 2021 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants