fix logging basicConfig cannot be setting after import paddle #17786
Merged
heavengate merged 5 commits intoPaddlePaddle:developfrom Jun 12, 2019
Merged
fix logging basicConfig cannot be setting after import paddle #17786heavengate merged 5 commits intoPaddlePaddle:developfrom
heavengate merged 5 commits intoPaddlePaddle:developfrom
Conversation
heavengate
changed the title
heavengate
changed the title
SunGaofeng
previously approved these changes
Jun 10, 2019
Contributor
SunGaofeng
left a comment
SunGaofeng
left a comment
There was a problem hiding this comment.
It is really hard work to modify so many files to fix this problem.
However, is it necessary to add some instructions or illustrations in develop guid, in case that someone else add that again? You may suggest the administrator or PMs to add this.
SunGaofeng
reviewed
Jun 10, 2019
Contributor
SunGaofeng
left a comment
SunGaofeng
left a comment
There was a problem hiding this comment.
using "grep -n basicConfig -r . " under python/paddle, it shows that 17 files include basicConfig, in the pr, 12 of them were fixed, please check again.
Contributor
Author
Done for change remain file to use get_logger |
qingqing01
approved these changes
Jun 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: logging.basicConfig can not be settting successfully after import paddle
Reason: logging.basicConfig has been set in paddle python code
Fix: add log_helper.py get_logger function to get logger with given name, level and format without setting logging.basicConfig