Skip to content

Revert "Enable SQRT operator for the nGraph Bridge"#17680

Merged
luotao1 merged 1 commit intodevelopfrom
revert-17549-kbinias/ngraph-sqrt-op
May 28, 2019
Merged

Revert "Enable SQRT operator for the nGraph Bridge"#17680
luotao1 merged 1 commit intodevelopfrom
revert-17549-kbinias/ngraph-sqrt-op

Conversation

@luotao1
Copy link
Contributor

@luotao1 luotao1 commented May 28, 2019

Reverts #17549

[22:16:34]	In file included from /paddle/build/paddle/fluid/operators/ngraph/ngraph_ops.h:12:0,
[22:16:34]	                 from /paddle/paddle/fluid/operators/ngraph/ngraph_bridge.cc:23:
[22:16:34]	/paddle/paddle/fluid/operators/ngraph/ops/activation_op.h: In constructor 'ng_sqrt_converter::ng_sqrt_converter()':
[22:16:34]	/paddle/paddle/fluid/operators/ngraph/ops/activation_op.h:116:101: error: 'BuildUnaryNode' is not a member of 'paddle::operators::ngraphs'
[22:16:34]	/paddle/paddle/fluid/operators/ngraph/ops/activation_op.h:116:160: error: expected primary-expression before '>' token
[22:16:34]	/paddle/paddle/fluid/operators/ngraph/ops/activation_op.h:116:161: error: expected primary-expression before ',' token
[22:16:34]	make[2]: *** [paddle/fluid/operators/ngraph/CMakeFiles/ngraph_bridge.dir/ngraph_bridge.cc.o] Error 1
[22:16:34]	paddle/fluid/operators/ngraph/CMakeFiles/ngraph_bridge.dir/build.make:62: recipe for target 'paddle/fluid/operators/ngraph/CMakeFiles/ngraph_bridge.dir/ngraph_bridge.cc.o' failed
[22:16:34]	make[1]: *** [paddle/fluid/operators/ngraph/CMakeFiles/ngraph_bridge.dir/all] Error 2
[22:16:34]	CMakeFiles/Makefile2:62623: recipe for target 'paddle/fluid/operators/ngraph/CMakeFiles/ngraph_bridge.dir/all' failed
[22:16:34]	make[1]: *** Waiting for unfinished jobs....
[22:16:35]	

http://ci.paddlepaddle.org/viewLog.html?buildId=105021&tab=buildLog&buildTypeId=Paddle_PrCi&logTab=tree&filter=all

Copy link
Contributor

@chengduoZH chengduoZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Contributor Author

luotao1 commented May 28, 2019

image
@kbinias

@luotao1 luotao1 merged commit 962eed6 into develop May 28, 2019
@luotao1 luotao1 deleted the revert-17549-kbinias/ngraph-sqrt-op branch May 28, 2019 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants