Skip to content

Enable less_than ngraph operator#17642

Merged
luotao1 merged 3 commits intoPaddlePaddle:developfrom
pawelpiotrowicz:pawepiot/less_than_ngraph_op
May 30, 2019
Merged

Enable less_than ngraph operator#17642
luotao1 merged 3 commits intoPaddlePaddle:developfrom
pawelpiotrowicz:pawepiot/less_than_ngraph_op

Conversation

@pawelpiotrowicz
Copy link
Contributor

@pawelpiotrowicz pawelpiotrowicz commented May 24, 2019

This PR is to enable less_than op for ngraph engine, it is needed for BERT model

@kbinias kbinias requested a review from mozga-intel May 24, 2019 15:14
@kbinias kbinias added this to the v1.5 for Intel milestone May 24, 2019
@luotao1
Copy link
Contributor

luotao1 commented May 26, 2019

Please add unit-test for this op.

@mozga-intel mozga-intel force-pushed the pawepiot/less_than_ngraph_op branch from 51c203a to b44e319 Compare May 29, 2019 17:30
Copy link
Contributor

@mozga-intel mozga-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baojun-nervana baojun-nervana requested a review from luotao1 May 29, 2019 17:36
Copy link
Contributor

@baojun-nervana baojun-nervana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Contributor

luotao1 commented May 30, 2019

@pawelpiotrowicz @mozga-intel @baojun-nervana please improve and perfect the description of all the PRs. #17642 (comment) "test=develop" is not a good description.

@baojun-nervana
Copy link
Contributor

baojun-nervana commented May 30, 2019

@pawelpiotrowicz @mozga-intel @baojun-nervana please improve and perfect the description of all the PRs. #17642 (comment) "test=develop" is not a good description.

Does the above description look good?

@luotao1
Copy link
Contributor

luotao1 commented May 30, 2019

Thanks @baojun-nervana, please improve and perfect the description of other ngraph PRs.

@luotao1 luotao1 merged commit 9b99876 into PaddlePaddle:develop May 30, 2019
@baojun-nervana baojun-nervana deleted the pawepiot/less_than_ngraph_op branch May 30, 2019 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants