Skip to content

code clean - refine ARM compile#17590

Merged
Superjomn merged 3 commits intoPaddlePaddle:incubate/litefrom
Superjomn:lite/arm-code-clean
May 23, 2019
Merged

code clean - refine ARM compile#17590
Superjomn merged 3 commits intoPaddlePaddle:incubate/litefrom
Superjomn:lite/arm-code-clean

Conversation

@Superjomn
Copy link
Contributor

cmake enhancement:

  • add lite_cc_library and lite_cc_test

code clean:

  • remove ARM feed and fetch kernels, reuse the Host's

remove unnecessary comments

cmake enhancement:

- add lite_cc_library and lite_cc_test

code clean:

- remove ARM feed and fetch kernels, reuse the Host's

remove unnecessary comments
@Superjomn Superjomn requested a review from tensor-tang May 23, 2019 09:02
@Superjomn Superjomn changed the title code clean - refine ARM code clean - refine ARM compile May 23, 2019
option(LITE_WITH_X86 "Enable X86 in lite mode" ON)
option(LITE_WITH_X86 "Enable X86 in lite mode" ON)
option(LITE_WITH_ARM "Enable ARM in lite mode" OFF)
option(LITE_WITH_LIGHT_WEIGHT_FRAMEWORK "Enable light-weight framework" OFF)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

比较疑惑LITE_WITH_ARMLITE_WITH_LIGHT_WEIGHT_FRAMEWORKWITH_LITE 这几个之间的关系

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WITH_LITE 控制整个lite 目录是否会编译
LITE_WITH_LIGHT_WEIGHT_FRAMEWORK 控制是否用轻量级框架, server端也可以用轻量级
LITE_WITH_ARM 是控制是否编译 ARM 相关模块,包括kernel等。 ARM 和 X86 以及 CUDA 都是平级的硬件,本质上不做特殊支持

暂时 LITE_WITH_LIGHT_WEIGHT_FRAMEWORK + LITE_WITH_ARM 可以认为是在mobile平台上跑

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LITE_WITH_LIGHT_WEIGHT_FRAMEWORK 控制是否用轻量级框架, server端也可以用轻量级

他指的是框架轻量级?lite本身的目的就是轻量级吧,是不是应该把他们合成一个?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lite 之后有可能会接入训练; 目前已有的 server op 都是基于重的框架,包括 allocator, tensor, scope, platform 等,短暂没法合并。

所以暂时只能 mobile 用轻量级,后面再看看

Copy link
Contributor

@tensor-tang tensor-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

希望后期可以把LITE_WITH_LIGHT_WEIGHT_FRAMEWORK 整理下,这个与WITH_LITE有点重复。

@Superjomn Superjomn merged commit 5912280 into PaddlePaddle:incubate/lite May 23, 2019
@Superjomn Superjomn deleted the lite/arm-code-clean branch May 23, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants