Skip to content

Enable elementwise mul operator test=develop#17552

Merged
tensor-tang merged 1 commit intoPaddlePaddle:developfrom
mozga-intel:mozga-intel/elementwise_mul_operator_ngraph
May 24, 2019
Merged

Enable elementwise mul operator test=develop#17552
tensor-tang merged 1 commit intoPaddlePaddle:developfrom
mozga-intel:mozga-intel/elementwise_mul_operator_ngraph

Conversation

@mozga-intel
Copy link
Contributor

Enable elementwise mull operator for the nGraph Bridge. BERT model uses this operator.

@mozga-intel mozga-intel force-pushed the mozga-intel/elementwise_mul_operator_ngraph branch from 3760d7a to b399851 Compare May 23, 2019 08:58
@luotao1 luotao1 requested a review from tensor-tang May 24, 2019 02:08
Copy link
Contributor

@tensor-tang tensor-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments please address in next PR.

@@ -0,0 +1,111 @@
/*Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2019

@@ -0,0 +1,22 @@
# Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above, and seems have some empty blanks.


import unittest, sys
sys.path.append("../")
from test_elementwise_mul_op import TestElementwiseMulOp_scalar, TestElementwiseMulOp_Vector, TestElementwiseMulOp_broadcast_0, TestElementwiseMulOp_broadcast_1, TestElementwiseMulOp_broadcast_2, TestElementwiseMulOp_broadcast_3
Copy link
Contributor

@tensor-tang tensor-tang May 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from test_elementwise_mul_op import *?

@tensor-tang tensor-tang merged commit 0d4cbda into PaddlePaddle:develop May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants