Add new gard clip [old gradient clip not support in dy graph]#17523
Merged
phlrain merged 16 commits intoPaddlePaddle:developfrom May 29, 2019
Merged
Add new gard clip [old gradient clip not support in dy graph]#17523phlrain merged 16 commits intoPaddlePaddle:developfrom
phlrain merged 16 commits intoPaddlePaddle:developfrom
Conversation
… add_new_gard_clip
… add_new_gard_clip
… add_new_gard_clip
… add_new_gard_clip
… add_new_gard_clip
to fix format problem
JiabinYang
previously approved these changes
May 28, 2019
| no_grad_set=no_grad_set) | ||
|
|
||
| if grad_clip is not None and framework.in_dygraph_mode(): | ||
| params_grads = grad_clip(params_grads) |
Contributor
There was a problem hiding this comment.
Add Warning to avoid static graph user to have unexpected effect
python/paddle/fluid/clip.py
Outdated
| ClipByNorm = GradientClipByNorm | ||
| ClipByGlobalNorm = GradientClipByGlobalNorm | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Maybe add TODO to clarify we will replace original grad_clip with this GradClip
| @@ -0,0 +1,254 @@ | |||
| # Copyright (c) 2019 PaddlePaddle Authors. All Rights Reserved. | |||
Contributor
There was a problem hiding this comment.
Better to rename this test with Dygraph
chengduoZH
previously approved these changes
May 28, 2019
XiaoguangHu01
previously approved these changes
May 28, 2019
phlrain
dismissed stale reviews from XiaoguangHu01, chengduoZH, JiabinYang, and shanyi15
via
fb0af78
shanyi15
approved these changes
May 28, 2019
XiaoguangHu01
approved these changes
May 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
old gradient clip not support in dy graph