Add broadcast operators#17503
Merged
chengduoZH merged 7 commits intoPaddlePaddle:developfrom May 24, 2019
Merged
Conversation
test=develop
chengduoZH
force-pushed
the
feature/dygraph_param_bcast
branch
from
fd952d0 to
3f7c77d
Compare
test=develop
chengduoZH
force-pushed
the
feature/dygraph_param_bcast
branch
from
3f7c77d to
e71d181
Compare
chengduoZH
force-pushed
the
feature/dygraph_param_bcast
branch
2 times, most recently
from
0ddf31a to
ce53b58
Compare
test=develop
chengduoZH
force-pushed
the
feature/dygraph_param_bcast
branch
from
ce53b58 to
2b3b07c
Compare
test=develop
chengduoZH
force-pushed
the
feature/dygraph_param_bcast
branch
from
626a5ed to
802bbf1
Compare
test=develop
chengduoZH
force-pushed
the
feature/dygraph_param_bcast
branch
from
802bbf1 to
5d641ba
Compare
JiabinYang
reviewed
May 23, 2019
Contributor
JiabinYang
left a comment
JiabinYang
left a comment
There was a problem hiding this comment.
can we have an unit test here?
Contributor
Author
There have two unit tests for dynamic graph training by multi-process, i.e. test_parallel_dygraph_mnist.py, test_parallel_dygraph_se_resnext.py |
Contributor
These tests are model-level, should we add op-level tests? |
test=develop
chengduoZH
force-pushed
the
feature/dygraph_param_bcast
branch
from
f7825d0 to
4b43823
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo: https://gist.github.com/chengduoZH/1a34d84c0672a46984bd17c16b6d9dd7
This PR adds broadcast for multi-process. And it could be used in dynamic graph to broadcast parameters.