Fix GetExpectedKernelType in Concat op#17459
Merged
jerrywgz merged 6 commits intoPaddlePaddle:developfrom May 23, 2019
Merged
Conversation
qingqing01
reviewed
May 18, 2019
paddle/fluid/operators/concat_op.cc
Outdated
| for (size_t i = 0; i < num_input; ++i) { | ||
| try { | ||
| input_data_type = | ||
| framework::GetDataTypeOfVar(ctx.MultiInputVar("X")[i]); |
Contributor
There was a problem hiding this comment.
line 83前先获取下 ctx.MultiInputVar("X")
auto vars = ctx.MultiInputVar("X");
auto input_data_type = paddle::framework::proto::VarType::Type(0);
for (size_t i = 0; i < vars.size(); ++i) {
try {
input_data_type = framework::GetDataTypeOfVar(vars[i]);
...
}
qingqing01
previously approved these changes
May 21, 2019
Contributor
qingqing01
left a comment
qingqing01
left a comment
There was a problem hiding this comment.
@chengduo Please help to review
chengduoZH
reviewed
May 22, 2019
| PADDLE_THROW("All Inputs of Concat OP are Empty!"); | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
The above implementation is a bit complicated.
You can try to fix like the following:
auto inputs = ctx.MultiInputVar("X");
for(auto* input : inputs){
if(input->IsInitialized()){
....
}
}
|
|
chengduoZH
approved these changes
May 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of #17015, concat op supports empty input now. If the first input is empty, then GetDataTypeOfVar will get Error. In this pr, GetExpectedKernelType is adjusted to get type of the first non-empty input.