add Concat quantization#17448
Merged
luotao1 merged 3 commits intoPaddlePaddle:developfrom May 27, 2019
sfraczek:concat-quantization
Merged
add Concat quantization#17448luotao1 merged 3 commits intoPaddlePaddle:developfrom sfraczek:concat-quantization
luotao1 merged 3 commits intoPaddlePaddle:developfrom
sfraczek:concat-quantization
Conversation
wojtuss
reviewed
May 16, 2019
wojtuss
reviewed
May 21, 2019
Author
|
I have to add use_quantizer flag to concat operator which because its missing in this PR |
wojtuss
previously approved these changes
May 23, 2019
added 3 commits
May 24, 2019 11:53
add unit test for quantizing concat fix for wrong value when the input is not in map of calculated scales add use_quantizer to concat_op.cc add scale_algo rules for concat test=develop
test=develop
wojtuss
approved these changes
May 27, 2019
Contributor
|
Which model uses this quantization, do you have some benchmark before and after this quantization? |
Author
|
Googlenet and mobilenet-ssd benefit from this (but we don't have test for mobilenet-ssd yet). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in files
graph_pattern_detector.cc, graph_pattern_detector.h, cpu_quantize_pass.cc, cpu_quantize_pass.h, mkldnn_quantizer.cc, mkldnn_quantizer.cc:in file
mkldnn_quantizer.cc: