Enable assign operator for a ngraph, test=develop#17437
Merged
tensor-tang merged 2 commits intoPaddlePaddle:developfrom May 24, 2019
Merged
Enable assign operator for a ngraph, test=develop#17437tensor-tang merged 2 commits intoPaddlePaddle:developfrom
tensor-tang merged 2 commits intoPaddlePaddle:developfrom
Conversation
mozga-intel
force-pushed
the
mozga-intel/assign_operator_ngraph
branch
2 times, most recently
from
8adfb6f to
22a222e
Compare
tensor-tang
reviewed
May 21, 2019
Contributor
tensor-tang
left a comment
tensor-tang
left a comment
There was a problem hiding this comment.
Additionally, the corss_entropy test was updated, due to that CI's test fails.
Could u give some more details about this ?
Contributor
Author
|
@tensor-tang The assign operator needs to support different shapes so any changes of xe operator are needed. The previous version of xe operator did not include these changes. |
Contributor
did not understand this
Actually I mean what is the test fails you said? |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the assign operator for the nGraph bridge. BERT model uses it.
Additionally, the corss_entropy test was updated, due to that CI's test fails.